Replace job instantiation that does not use JobMaker#338
Merged
Conversation
SmashPhil
reviewed
May 29, 2026
SmashPhil
requested changes
May 29, 2026
SmashPhil
previously approved these changes
May 29, 2026
… while out of fuel (SmashPhil#336) * Fixed an errror that occurred when attempting to set out on a caravan while out of fuel * Added draft check within LoadToilTick to LordToil_PrepareCaravan_LeaveWithVehicles
SmashPhil
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I left CarryPawnToVehicle as-is as the only use case for Job_Vehicle, but it’s possible that this will continue to increase within the job pool?
For the part where the job is being replaced by Harmony, the original job is returned to the pool. No reservation is made, so release is not specifically performed.